From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 18 Mar 2019 11:21:27 +0000 (+0100)
Subject: core: rename unit_{start_limit|condition|assert}_test() to unit_test_xyz()
X-Git-Tag: v242-rc1~108^2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=97a3f4ee052e1b8a0ff03accfa478e352891a84f;p=thirdparty%2Fsystemd.git

core: rename unit_{start_limit|condition|assert}_test() to unit_test_xyz()

Just some renaming, no change in behaviour.

Background: I'd like to add more functions unit_test_xyz() that test
various things, hence let's streamline the naming a bit.
---

diff --git a/src/core/automount.c b/src/core/automount.c
index 6a8373920ea..eff357bb3de 100644
--- a/src/core/automount.c
+++ b/src/core/automount.c
@@ -813,7 +813,7 @@ static int automount_start(Unit *u) {
                 return -ENOENT;
         }
 
-        r = unit_start_limit_test(u);
+        r = unit_test_start_limit(u);
         if (r < 0) {
                 automount_enter_dead(a, AUTOMOUNT_FAILURE_START_LIMIT_HIT);
                 return r;
diff --git a/src/core/mount.c b/src/core/mount.c
index 8da818beeee..a991bf8794d 100644
--- a/src/core/mount.c
+++ b/src/core/mount.c
@@ -1104,7 +1104,7 @@ static int mount_start(Unit *u) {
 
         assert(IN_SET(m->state, MOUNT_DEAD, MOUNT_FAILED));
 
-        r = unit_start_limit_test(u);
+        r = unit_test_start_limit(u);
         if (r < 0) {
                 mount_enter_dead(m, MOUNT_FAILURE_START_LIMIT_HIT);
                 return r;
diff --git a/src/core/path.c b/src/core/path.c
index 831e49df29f..a7a7ec28aef 100644
--- a/src/core/path.c
+++ b/src/core/path.c
@@ -567,7 +567,7 @@ static int path_start(Unit *u) {
                 return -ENOENT;
         }
 
-        r = unit_start_limit_test(u);
+        r = unit_test_start_limit(u);
         if (r < 0) {
                 path_enter_dead(p, PATH_FAILURE_START_LIMIT_HIT);
                 return r;
diff --git a/src/core/service.c b/src/core/service.c
index fc4e92389bb..bbe55322099 100644
--- a/src/core/service.c
+++ b/src/core/service.c
@@ -2364,7 +2364,7 @@ static int service_start(Unit *u) {
         assert(IN_SET(s->state, SERVICE_DEAD, SERVICE_FAILED));
 
         /* Make sure we don't enter a busy loop of some kind. */
-        r = unit_start_limit_test(u);
+        r = unit_test_start_limit(u);
         if (r < 0) {
                 service_enter_dead(s, SERVICE_FAILURE_START_LIMIT_HIT, false);
                 return r;
diff --git a/src/core/socket.c b/src/core/socket.c
index 3b60914c867..fd550290bea 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -2487,7 +2487,7 @@ static int socket_start(Unit *u) {
 
         assert(IN_SET(s->state, SOCKET_DEAD, SOCKET_FAILED));
 
-        r = unit_start_limit_test(u);
+        r = unit_test_start_limit(u);
         if (r < 0) {
                 socket_enter_dead(s, SOCKET_FAILURE_START_LIMIT_HIT);
                 return r;
diff --git a/src/core/swap.c b/src/core/swap.c
index 2d8463b8b18..b836fdd3046 100644
--- a/src/core/swap.c
+++ b/src/core/swap.c
@@ -871,7 +871,7 @@ static int swap_start(Unit *u) {
                 if (UNIT(other)->job && UNIT(other)->job->state == JOB_RUNNING)
                         return -EAGAIN;
 
-        r = unit_start_limit_test(u);
+        r = unit_test_start_limit(u);
         if (r < 0) {
                 swap_enter_dead(s, SWAP_FAILURE_START_LIMIT_HIT);
                 return r;
diff --git a/src/core/timer.c b/src/core/timer.c
index 0c1ca3ef233..736ffaa437a 100644
--- a/src/core/timer.c
+++ b/src/core/timer.c
@@ -607,7 +607,7 @@ static int timer_start(Unit *u) {
                 return -ENOENT;
         }
 
-        r = unit_start_limit_test(u);
+        r = unit_test_start_limit(u);
         if (r < 0) {
                 timer_enter_dead(t, TIMER_FAILURE_START_LIMIT_HIT);
                 return r;
diff --git a/src/core/unit.c b/src/core/unit.c
index 4f89db02b65..9f75c976827 100644
--- a/src/core/unit.c
+++ b/src/core/unit.c
@@ -1633,7 +1633,7 @@ static bool unit_condition_test_list(Unit *u, Condition *first, const char *(*to
         return triggered != 0;
 }
 
-static bool unit_condition_test(Unit *u) {
+static bool unit_test_condition(Unit *u) {
         assert(u);
 
         dual_timestamp_get(&u->condition_timestamp);
@@ -1644,7 +1644,7 @@ static bool unit_condition_test(Unit *u) {
         return u->condition_result;
 }
 
-static bool unit_assert_test(Unit *u) {
+static bool unit_test_assert(Unit *u) {
         assert(u);
 
         dual_timestamp_get(&u->assert_timestamp);
@@ -1667,7 +1667,7 @@ void unit_status_printf(Unit *u, const char *status, const char *unit_status_msg
         REENABLE_WARNING;
 }
 
-int unit_start_limit_test(Unit *u) {
+int unit_test_start_limit(Unit *u) {
         const char *reason;
 
         assert(u);
@@ -1764,14 +1764,14 @@ int unit_start(Unit *u) {
          * speed up activation in case there is some hold-off time,
          * but we don't want to recheck the condition in that case. */
         if (state != UNIT_ACTIVATING &&
-            !unit_condition_test(u)) {
+            !unit_test_condition(u)) {
                 log_unit_debug(u, "Starting requested but condition failed. Not starting unit.");
                 return -ECOMM;
         }
 
         /* If the asserts failed, fail the entire job */
         if (state != UNIT_ACTIVATING &&
-            !unit_assert_test(u)) {
+            !unit_test_assert(u)) {
                 log_unit_notice(u, "Starting requested but asserts failed.");
                 return -EPROTO;
         }
diff --git a/src/core/unit.h b/src/core/unit.h
index 90d5e6f49db..8c67676c8ae 100644
--- a/src/core/unit.h
+++ b/src/core/unit.h
@@ -778,7 +778,7 @@ static inline bool unit_supported(Unit *u) {
 void unit_warn_if_dir_nonempty(Unit *u, const char* where);
 int unit_fail_if_noncanonical(Unit *u, const char* where);
 
-int unit_start_limit_test(Unit *u);
+int unit_test_start_limit(Unit *u);
 
 void unit_unref_uid(Unit *u, bool destroy_now);
 int unit_ref_uid(Unit *u, uid_t uid, bool clean_ipc);