From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 26 Aug 2022 14:31:30 +0000 (+0200)
Subject: compare: drop use of FNM_EXTMATCH for now
X-Git-Tag: v252-rc1~273^2~13
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=97c7bed90a4083184fadd3c6d24cc38fc487161d;p=thirdparty%2Fsystemd.git

compare: drop use of FNM_EXTMATCH for now

None of our other fnmatch() calls make use of this, and the concept was
new to me at least. Given that this is only used for the recently added
SMBIOS field matches (and is not included in any release) let's disable
"extended" matches for now. We can certainly revisit this, and enable it
later if there is real demand, but if we do, we should probably add that
all over the place, not just for smbios matches.
---

diff --git a/src/shared/compare-operator.c b/src/shared/compare-operator.c
index 4baf57a35df..a5b6c1ac6b9 100644
--- a/src/shared/compare-operator.c
+++ b/src/shared/compare-operator.c
@@ -74,10 +74,10 @@ int version_or_fnmatch_compare(
         switch (op) {
 
         case COMPARE_FNMATCH_EQUAL:
-                return fnmatch(b, a, FNM_EXTMATCH) != FNM_NOMATCH;
+                return fnmatch(b, a, 0) != FNM_NOMATCH;
 
         case COMPARE_FNMATCH_UNEQUAL:
-                return fnmatch(b, a, FNM_EXTMATCH) == FNM_NOMATCH;
+                return fnmatch(b, a, 0) == FNM_NOMATCH;
 
         case _COMPARE_OPERATOR_ORDER_FIRST..._COMPARE_OPERATOR_ORDER_LAST:
                 return test_order(strverscmp_improved(a, b), op);