From: Pablo Galindo Salgado <Pablogsal@gmail.com>
Date: Tue, 6 Dec 2022 23:09:56 +0000 (+0000)
Subject: gh-100050: Fix an assertion error when raising unclosed parenthesis errors in the... 
X-Git-Tag: v3.12.0a4~280
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=97e7004cfe48305bcd642c653b406dc7470e196d;p=thirdparty%2FPython%2Fcpython.git

gh-100050: Fix an assertion error when raising unclosed parenthesis errors in the tokenizer (GH-100065)



Automerge-Triggered-By: GH:pablogsal
---

diff --git a/Lib/test/test_syntax.py b/Lib/test/test_syntax.py
index 78cac231929a..cb284195d976 100644
--- a/Lib/test/test_syntax.py
+++ b/Lib/test/test_syntax.py
@@ -2145,6 +2145,22 @@ def func2():
         for paren in ")]}":
             self._check_error(paren + "1 + 2", f"unmatched '\\{paren}'")
 
+        # Some more complex examples:
+        code = """\
+func(
+    a=["unclosed], # Need a quote in this comment: "
+    b=2,
+)
+"""
+        self._check_error(code, "parenthesis '\\)' does not match opening parenthesis '\\['")
+
+    def test_error_string_literal(self):
+
+        self._check_error("'blech", "unterminated string literal")
+        self._check_error('"blech', "unterminated string literal")
+        self._check_error("'''blech", "unterminated triple-quoted string literal")
+        self._check_error('"""blech', "unterminated triple-quoted string literal")
+
     def test_invisible_characters(self):
         self._check_error('print\x17("Hello")', "invalid non-printable character")
 
diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-12-06-22-24-01.gh-issue-100050.lcrPqQ.rst b/Misc/NEWS.d/next/Core and Builtins/2022-12-06-22-24-01.gh-issue-100050.lcrPqQ.rst
new file mode 100644
index 000000000000..8e7c72d804f8
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2022-12-06-22-24-01.gh-issue-100050.lcrPqQ.rst	
@@ -0,0 +1,2 @@
+Honor existing errors obtained when searching for mismatching parentheses in
+the tokenizer. Patch by Pablo Galindo
diff --git a/Parser/pegen_errors.c b/Parser/pegen_errors.c
index 7738cbaf9ef3..6ea7600119b6 100644
--- a/Parser/pegen_errors.c
+++ b/Parser/pegen_errors.c
@@ -169,6 +169,10 @@ _PyPegen_tokenize_full_source_to_check_for_errors(Parser *p) {
     for (;;) {
         switch (_PyTokenizer_Get(p->tok, &new_token)) {
             case ERRORTOKEN:
+                if (PyErr_Occurred()) {
+                    ret = -1;
+                    goto exit;
+                }
                 if (p->tok->level != 0) {
                     int error_lineno = p->tok->parenlinenostack[p->tok->level-1];
                     if (current_err_line > error_lineno) {