From: Jerome Marchand <jmarchan@redhat.com>
Date: Thu, 9 Sep 2010 23:37:59 +0000 (-0700)
Subject: kernel/groups.c: fix integer overflow in groups_search
X-Git-Tag: v2.6.34.8~192
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=982ce55c5ea05debc2ca705e936580f905745618;p=thirdparty%2Fkernel%2Fstable.git

kernel/groups.c: fix integer overflow in groups_search

commit 1c24de60e50fb19b94d94225458da17c720f0729 upstream.

gid_t is a unsigned int.  If group_info contains a gid greater than
MAX_INT, groups_search() function may look on the wrong side of the search
tree.

This solves some unfair "permission denied" problems.

Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

diff --git a/kernel/groups.c b/kernel/groups.c
index 2b45b2ee3964f..f0c2528f56fe4 100644
--- a/kernel/groups.c
+++ b/kernel/groups.c
@@ -143,10 +143,9 @@ int groups_search(const struct group_info *group_info, gid_t grp)
 	right = group_info->ngroups;
 	while (left < right) {
 		unsigned int mid = (left+right)/2;
-		int cmp = grp - GROUP_AT(group_info, mid);
-		if (cmp > 0)
+		if (grp > GROUP_AT(group_info, mid))
 			left = mid + 1;
-		else if (cmp < 0)
+		else if (grp < GROUP_AT(group_info, mid))
 			right = mid;
 		else
 			return 1;