From: Joe Orton <jorton@apache.org>
Date: Fri, 17 Jul 2026 12:12:40 +0000 (+0000)
Subject: mod_ssl: fix set_challenge_creds() to return rv on failure
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=984a3456df1a2c721282d4f2255afd4539006a05;p=thirdparty%2Fapache%2Fhttpd.git

mod_ssl: fix set_challenge_creds() to return rv on failure

* modules/ssl/ssl_engine_kernel.c (set_challenge_creds): Return rv
  rather than APR_SUCCESS unconditionally, so credential setup
  failures are propagated to the ALPN selection callback.

Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
GitHub: PR #685


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1936262 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/ssl/ssl_engine_kernel.c b/modules/ssl/ssl_engine_kernel.c
index 9ee25ec52c..3e96f9efda 100644
--- a/modules/ssl/ssl_engine_kernel.c
+++ b/modules/ssl/ssl_engine_kernel.c
@@ -2238,7 +2238,7 @@ static apr_status_t set_challenge_creds(conn_rec *c, const char *servername,
 cleanup:
     if (our_data && cert) X509_free(cert);
     if (our_data && key) EVP_PKEY_free(key);
-    return APR_SUCCESS;
+    return rv;
 }
   
 /*