From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 3 May 2016 18:16:14 +0000 (-0400)
Subject: Treat absent argument to crypto_log_errors as a bug.
X-Git-Tag: tor-0.2.9.1-alpha~240^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=98a590577a1064e2d0134a291c76a62fe6469a3c;p=thirdparty%2Ftor.git

Treat absent argument to crypto_log_errors as a bug.
---

diff --git a/src/common/crypto.c b/src/common/crypto.c
index 71cab24d1d..24a9590cd6 100644
--- a/src/common/crypto.c
+++ b/src/common/crypto.c
@@ -171,13 +171,9 @@ crypto_log_errors(int severity, const char *doing)
     if (!msg) msg = "(null)";
     if (!lib) lib = "(null)";
     if (!func) func = "(null)";
-    if (doing) {
-      tor_log(severity, LD_CRYPTO, "crypto error while %s: %s (in %s:%s)",
+    if (BUG(!doing)) doing = "(null)";
+    tor_log(severity, LD_CRYPTO, "crypto error while %s: %s (in %s:%s)",
               doing, msg, lib, func);
-    } else {
-      tor_log(severity, LD_CRYPTO, "crypto error: %s (in %s:%s)",
-              msg, lib, func);
-    }
   }
 }