From: Ondřej Surý <ondrej@isc.org>
Date: Wed, 11 Mar 2026 12:17:56 +0000 (+0100)
Subject: Fix INSIST copy-paste error checking RADIX_V4 instead of RADIX_V6
X-Git-Tag: v9.20.22~2^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=98f5caea05f3140862581ddb3b7d3815a04ead2d;p=thirdparty%2Fbind9.git

Fix INSIST copy-paste error checking RADIX_V4 instead of RADIX_V6

The INSIST in isc_radix_insert() checks node->data[RADIX_V4] and
node->node_num[RADIX_V4] twice due to a copy-paste error, never
verifying the RADIX_V6 fields.

Fix the second pair to check RADIX_V6.

(cherry picked from commit 3f15f2d9e5968d6e03c4dc89cd7aea097f9c3ced)
---

diff --git a/lib/isc/radix.c b/lib/isc/radix.c
index 31cceed1b01..a62fdde38c5 100644
--- a/lib/isc/radix.c
+++ b/lib/isc/radix.c
@@ -458,8 +458,8 @@ isc_radix_insert(isc_radix_tree_t *radix, isc_radix_node_t **target,
 		}
 		INSIST(node->data[RADIX_V4] == NULL &&
 		       node->node_num[RADIX_V4] == -1 &&
-		       node->data[RADIX_V4] == NULL &&
-		       node->node_num[RADIX_V4] == -1);
+		       node->data[RADIX_V6] == NULL &&
+		       node->node_num[RADIX_V6] == -1);
 		if (source != NULL) {
 			/* Merging node */
 			for (i = 0; i < RADIX_FAMILIES; i++) {