From: Aram Sargsyan <aram@isc.org>
Date: Wed, 15 Jun 2022 12:58:00 +0000 (+0000)
Subject: Fix DiG query retry and fail-over bug
X-Git-Tag: v9.19.4~13^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=99085c587e0cd235797f980810d32b9dcf960df2;p=thirdparty%2Fbind9.git

Fix DiG query retry and fail-over bug

When the `send_done()` callback function gets called with a failure
result code, DiG erroneously cancels the lookup.

Stop canceling the lookup and give DiG a chance to retry the failed
query, or fail-over to another server, using the logic implemented in
the `recv_done()` callback function.
---

diff --git a/bin/dig/dighost.c b/bin/dig/dighost.c
index e7bd59b1c91..418540d1b4d 100644
--- a/bin/dig/dighost.c
+++ b/bin/dig/dighost.c
@@ -2695,7 +2695,6 @@ send_done(isc_nmhandle_t *handle, isc_result_t eresult, void *arg) {
 		return;
 	} else if (eresult != ISC_R_SUCCESS) {
 		debug("send failed: %s", isc_result_totext(eresult));
-		cancel_lookup(l);
 		query_detach(&query);
 		lookup_detach(&l);
 		UNLOCK_LOOKUP;