From: Nick Mathewson <nickm@torproject.org>
Date: Fri, 23 Nov 2012 15:06:16 +0000 (-0500)
Subject: Note limitation of parse_rfc_1123_time
X-Git-Tag: tor-0.2.4.7-alpha~27
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=99669c69b3ad424c02393c97b48795eba6fb36bb;p=thirdparty%2Ftor.git

Note limitation of parse_rfc_1123_time

RFC1123 suggests that we should handle two-year times, and a full
range of time zones, and other stuff too.  We don't.
---

diff --git a/src/common/util.c b/src/common/util.c
index 44cdd64d6b..61d09aa4a8 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -1408,6 +1408,9 @@ format_rfc1123_time(char *buf, time_t t)
 /** Parse the (a subset of) the RFC1123 encoding of some time (in UTC) from
  * <b>buf</b>, and store the result in *<b>t</b>.
  *
+ * Note that we only accept the subset generated by format_rfc1123_time above,
+ * not the full range of formats suggested by RFC 1123.
+ *
  * Return 0 on success, -1 on failure.
 */
 int