From: Amos Jeffries <squid3@treenet.co.nz>
Date: Wed, 12 Nov 2008 04:55:12 +0000 (+1300)
Subject: Correct debugs output on GetDenyInfo
X-Git-Tag: SQUID_3_2_0_1~1335
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=99697e8e104ac18aba958f4d261ba12fda8f90d1;p=thirdparty%2Fsquid.git

Correct debugs output on GetDenyInfo

deny_info pages are expected to be redirects sometimes.
It's only the particular lookup which can't use them.
Also they may not be a match anyway since test was done after warning.
---

diff --git a/src/acl_noncore.cc b/src/acl_noncore.cc
index fc3c5dfdb9..3ae626a2b8 100644
--- a/src/acl_noncore.cc
+++ b/src/acl_noncore.cc
@@ -52,20 +52,19 @@ aclGetDenyInfoPage(acl_deny_info_list ** head, const char *name, int redirect_al
 {
     acl_deny_info_list *A = NULL;
 
-    debugs(28, 9, "aclGetDenyInfoPage: got called for " << name);
-
+    debugs(28, 8, HERE << "got called for " << name);
 
     for (A = *head; A; A = A->next) {
         acl_name_list *L = NULL;
 
-        if (!redirect_allowed && strchr(A->err_page_name, ':')) {
-            debugs(28, 3, "aclGetDenyInfoPage: WARNING, unexpected codepath taken");
+        if (!redirect_allowed && strchr(A->err_page_name, ':') ) {
+            debugs(28, 8, HERE << "Skip '" << A->err_page_name << "' 30x redirects not allowed as response here.");
             continue;
         }
 
         for (L = A->acl_list; L; L = L->next) {
             if (!strcmp(name, L->name)) {
-                debugs(28, 8, "aclGetDenyInfoPage: match on " << name);
+                debugs(28, 8, HERE << "match on " << name);
                 return A->err_page_id;
             }