From: Jim Meyering <jim@meyering.net>
Date: Tue, 14 Dec 2004 10:28:03 +0000 (+0000)
Subject: 	[DONT_UNLINK_WHILE_OPEN]: Add a FIXME comment explaining that
X-Git-Tag: v5.3.0~137
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9a13cce9ec3bd1f96cef1a043194bd5524bbb4c4;p=thirdparty%2Fcoreutils.git

	[DONT_UNLINK_WHILE_OPEN]: Add a FIXME comment explaining that
	using atexit like this is wrong.
---

diff --git a/src/tac.c b/src/tac.c
index ba206c1eff..4f6fb229a1 100644
--- a/src/tac.c
+++ b/src/tac.c
@@ -375,6 +375,12 @@ tac_seekable (int input_fd, const char *file)
 
 #if DONT_UNLINK_WHILE_OPEN
 
+/* FIXME-someday: remove all of this DONT_UNLINK_WHILE_OPEN junk.
+   Using atexit like this is wrong, since it can fail
+   when called e.g. 32 or more times.
+   But this isn't a big deal, since the code is used only on WOE/DOS
+   systems, and few people invoke tac on that many nonseekable files.  */
+
 static const char *file_to_remove;
 static FILE *fp_to_close;