From: stratakis Date: Wed, 17 Jun 2020 19:43:27 +0000 (+0200) Subject: [3.9] bpo-40637: Do not emit warnings for disabled builtin hashes (GH… (GH-20951) X-Git-Tag: v3.9.0b4~74 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9a58f03dc21d15c076d051d902ce1d0324db9741;p=thirdparty%2FPython%2Fcpython.git [3.9] bpo-40637: Do not emit warnings for disabled builtin hashes (GH… (GH-20951) …-20937) test_hashlib emits some warnings when it cannot find some hashes as it assumes they failed to compile. Since we can disable hashes through configure, we emit the warnings only in the case that we did not intentionaly disable them. Automerge-Triggered-By: @tiran (cherry picked from commit 236a0f5) Co-authored-by: stratakis --- diff --git a/Lib/test/test_hashlib.py b/Lib/test/test_hashlib.py index 6088307f8410..86f20a7aff83 100644 --- a/Lib/test/test_hashlib.py +++ b/Lib/test/test_hashlib.py @@ -102,7 +102,7 @@ class HashLibTestCase(unittest.TestCase): try: return importlib.import_module(module_name) except ModuleNotFoundError as error: - if self._warn_on_extension_import: + if self._warn_on_extension_import and module_name in builtin_hashes: warnings.warn('Did a C extension fail to compile? %s' % error) return None