From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 23 Sep 2019 08:55:43 +0000 (+0200)
Subject: libssh: part of conditional expression is always true: !result
X-Git-Tag: curl-7_67_0~129
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9aed993da0e33e9aea27bfcd2ebcb9e7181d99c0;p=thirdparty%2Fcurl.git

libssh: part of conditional expression is always true: !result

PVS-Studio warning
Fixed #4402
---

diff --git a/lib/vssh/libssh.c b/lib/vssh/libssh.c
index 34ae792c3a..cad8b37864 100644
--- a/lib/vssh/libssh.c
+++ b/lib/vssh/libssh.c
@@ -1999,7 +1999,7 @@ static CURLcode myssh_block_statemach(struct connectdata *conn,
       }
     }
 
-    if(!result && block) {
+    if(block) {
       curl_socket_t fd_read = conn->sock[FIRSTSOCKET];
       /* wait for the socket to become ready */
       (void) Curl_socket_check(fd_read, CURL_SOCKET_BAD,