From: olav%bkor.dhs.org <>
Date: Wed, 15 Nov 2006 04:51:04 +0000 (+0000)
Subject: Do commit-time fix: Add comment explaining the sql modes that are removed
X-Git-Tag: bugzilla-2.23.4~212
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9b1749e4fab6dce06687b3610ee6fa049cf2c8f2;p=thirdparty%2Fbugzilla.git

Do commit-time fix: Add comment explaining the sql modes that are removed
---

diff --git a/Bugzilla/DB/Mysql.pm b/Bugzilla/DB/Mysql.pm
index b3b1cba10f..d9e6a25101 100644
--- a/Bugzilla/DB/Mysql.pm
+++ b/Bugzilla/DB/Mysql.pm
@@ -68,6 +68,9 @@ sub new {
     # Bug 321645 - disable MySQL strict mode, if set
     my $sql_mode = $self->selectrow_array('SELECT @@sql_mode');
     if ($sql_mode) {
+        # STRICT_TRANS_TABLE or STICT_ALL_TABLES enable MySQL strict mode,
+        # causing bug 321645. TRADITIONAL sets these modes (among others) as
+        # well, so it has to be stipped as well
         my $new_sql_mode =
             join(",", grep {$_ !~ /^STRICT_(?:TRANS|ALL)_TABLES|TRADITIONAL$/}
                             split(/,/, $sql_mode));