From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 11 Feb 2013 21:32:13 +0000 (-0500)
Subject: Fix a null-deref-on-fail in unit tests
X-Git-Tag: tor-0.2.4.11-alpha~37
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9b2bb901d7c306fd6ca28de527e86379470db89a;p=thirdparty%2Ftor.git

Fix a null-deref-on-fail in unit tests

If geoip_format_bridge_stats() returned NULL when it should have
returned a string, we would have tried to deref NULL, and died.  Not
a big deal in the unit tests, but still worth fixing.

Found by coverity; This is CID 743384.
---

diff --git a/src/test/test.c b/src/test/test.c
index be0737ceb7..6c64d35990 100644
--- a/src/test/test.c
+++ b/src/test/test.c
@@ -1678,6 +1678,7 @@ test_geoip(void)
    * the connecting clients added above. */
   geoip_bridge_stats_init(now);
   s = geoip_format_bridge_stats(now + 86400);
+  test_assert(s);
   test_streq(bridge_stats_1, s);
   tor_free(s);