From: Günther Deschner <gd@samba.org>
Date: Wed, 19 Nov 2008 22:02:49 +0000 (+0100)
Subject: s3-rpcclient: fix cmd_ntsvcs_get_dev_reg_prop.
X-Git-Tag: samba-4.0.0alpha6~480^2~173^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9b40d26e30518c666e4dad9cf55ec319cf19e28e;p=thirdparty%2Fsamba.git

s3-rpcclient: fix cmd_ntsvcs_get_dev_reg_prop.

Guenther
---

diff --git a/source3/rpcclient/cmd_ntsvcs.c b/source3/rpcclient/cmd_ntsvcs.c
index 11f16d34629..eb620d06b26 100644
--- a/source3/rpcclient/cmd_ntsvcs.c
+++ b/source3/rpcclient/cmd_ntsvcs.c
@@ -149,13 +149,13 @@ static WERROR cmd_ntsvcs_get_dev_reg_prop(struct rpc_pipe_client *cli,
 	const char *devicepath = NULL;
 	uint32_t property = DEV_REGPROP_DESC;
 	uint32_t reg_data_type = REG_NONE;
-	uint8_t buffer;
+	uint8_t *buffer;
 	uint32_t buffer_size = 0;
 	uint32_t needed = 0;
 	uint32_t flags = 0;
 
 	if (argc < 2) {
-		printf("usage: %s [devicepath]\n", argv[0]);
+		printf("usage: %s [devicepath] [buffersize]\n", argv[0]);
 		return WERR_OK;
 	}
 
@@ -166,11 +166,14 @@ static WERROR cmd_ntsvcs_get_dev_reg_prop(struct rpc_pipe_client *cli,
 		needed = buffer_size;
 	}
 
+	buffer = talloc_array(mem_ctx, uint8_t, buffer_size);
+	W_ERROR_HAVE_NO_MEMORY(buffer);
+
 	status = rpccli_PNP_GetDeviceRegProp(cli, mem_ctx,
 					     devicepath,
 					     property,
 					     &reg_data_type,
-					     &buffer,
+					     buffer,
 					     &buffer_size,
 					     &needed,
 					     flags,