From: Senthil Kumaran <orsenthil@gmail.com>
Date: Fri, 17 Sep 2010 16:35:37 +0000 (+0000)
Subject: Fix Issue2236: Distutils' mkpath implementation ignoring the "mode" parameter
X-Git-Tag: v3.2a3~237
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9b86a69fc7ee51deadf59a562cdce41aa698ce9b;p=thirdparty%2FPython%2Fcpython.git

Fix Issue2236: Distutils' mkpath implementation ignoring the "mode" parameter
---

diff --git a/Lib/distutils/dir_util.py b/Lib/distutils/dir_util.py
index 98e6252c6c70..54376e5ca5a3 100644
--- a/Lib/distutils/dir_util.py
+++ b/Lib/distutils/dir_util.py
@@ -68,7 +68,7 @@ def mkpath(name, mode=0o777, verbose=1, dry_run=0):
 
         if not dry_run:
             try:
-                os.mkdir(head)
+                os.mkdir(head, mode)
                 created_dirs.append(head)
             except OSError as exc:
                 raise DistutilsFileError(
diff --git a/Lib/distutils/tests/test_dir_util.py b/Lib/distutils/tests/test_dir_util.py
index 0f694aa0202a..8986ca55d4e0 100644
--- a/Lib/distutils/tests/test_dir_util.py
+++ b/Lib/distutils/tests/test_dir_util.py
@@ -1,6 +1,7 @@
 """Tests for distutils.dir_util."""
 import unittest
 import os
+import stat
 import shutil
 
 from distutils.dir_util import (mkpath, remove_tree, create_tree, copy_tree,
@@ -48,6 +49,12 @@ class DirUtilTestCase(support.TempdirManager, unittest.TestCase):
         wanted = ["removing '%s' (and everything under it)" % self.root_target]
         self.assertEquals(self._logs, wanted)
 
+    def test_mkpath_with_custom_mode(self):
+        mkpath(self.target, 0o700)
+        self.assertEqual(stat.S_IMODE(os.stat(self.target).st_mode), 0o700)
+        mkpath(self.target2, 0o555)
+        self.assertEqual(stat.S_IMODE(os.stat(self.target2).st_mode), 0o555)
+
     def test_create_tree_verbosity(self):
 
         create_tree(self.root_target, ['one', 'two', 'three'], verbose=0)