From: Martin DeMello <martindemello@fb.com>
Date: Fri, 28 Mar 2025 23:58:17 +0000 (-0700)
Subject: gh-131740: minor readability fix in PyUnstable_GC_VisitObjects (gh-131786)
X-Git-Tag: v3.14.0a7~152
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9c1e85fd64cf6a85f7c96390d7b2dfad03a76944;p=thirdparty%2FPython%2Fcpython.git

gh-131740: minor readability fix in PyUnstable_GC_VisitObjects (gh-131786)

Minor readability fix in PyUnstable_GC_VisitObjects

Replaces `if (visit_generation())` with `if (visit_generation() < 0)`,
since we are checking for the failure case, and it's confusing to have
that be implicitly `true`.

Also fixes a misspelt variable name.
---

diff --git a/Python/gc.c b/Python/gc.c
index 8d7f6ac2f3ab..e37d4b76456a 100644
--- a/Python/gc.c
+++ b/Python/gc.c
@@ -2407,20 +2407,20 @@ void
 PyUnstable_GC_VisitObjects(gcvisitobjects_t callback, void *arg)
 {
     GCState *gcstate = get_gc_state();
-    int origenstate = gcstate->enabled;
+    int original_state = gcstate->enabled;
     gcstate->enabled = 0;
-    if (visit_generation(callback, arg, &gcstate->young)) {
+    if (visit_generation(callback, arg, &gcstate->young) < 0) {
         goto done;
     }
-    if (visit_generation(callback, arg, &gcstate->old[0])) {
+    if (visit_generation(callback, arg, &gcstate->old[0]) < 0) {
         goto done;
     }
-    if (visit_generation(callback, arg, &gcstate->old[1])) {
+    if (visit_generation(callback, arg, &gcstate->old[1]) < 0) {
         goto done;
     }
     visit_generation(callback, arg, &gcstate->permanent_generation);
 done:
-    gcstate->enabled = origenstate;
+    gcstate->enabled = original_state;
 }
 
 #endif  // Py_GIL_DISABLED