From: Sjoerd Mullender <sjoerd@acm.org>
Date: Tue, 15 Aug 1995 11:33:39 +0000 (+0000)
Subject: Removed addbase.__del__ because it can't work.
X-Git-Tag: v1.3b1~25
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9c4585acfa28cd460c80b9b3ab6de5c257eaeec5;p=thirdparty%2FPython%2Fcpython.git

Removed addbase.__del__ because it can't work.
If code keeps a reference to self.fp or any of its methods, you don't
want to close self.fp just because no explicit reference is kept to self.
---

diff --git a/Lib/urllib.py b/Lib/urllib.py
index 380a852e14bb..f83bafd64d5e 100644
--- a/Lib/urllib.py
+++ b/Lib/urllib.py
@@ -442,8 +442,12 @@ class addbase:
 	def __repr__(self):
 		return '<%s at %s whose fp = %s>' % (
 			  self.__class__.__name__, `id(self)`, `self.fp`)
-	def __del__(self):
-		self.close()
+# Removed this __del__ because it can't work like this.  If a
+# reference is kept to self.fp or any of its methods, but no reference
+# is kept to self, we don't want to close self.fp (which would happen
+# if this __del__ still existed).
+#	def __del__(self):
+#		self.close()
 	def close(self):
 		self.read = None
 		self.readline = None