From: Guido van Rossum <guido@python.org>
Date: Sun, 12 Jan 1997 20:02:04 +0000 (+0000)
Subject: Fix leak involving BuildValue("...O...").
X-Git-Tag: v1.5a1~538
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9c6ba5e901026225b11648ce11ba9d8305286113;p=thirdparty%2FPython%2Fcpython.git

Fix leak involving BuildValue("...O...").
---

diff --git a/Modules/binascii.c b/Modules/binascii.c
index 62beaeab018e..c4c97b5d7853 100644
--- a/Modules/binascii.c
+++ b/Modules/binascii.c
@@ -492,9 +492,13 @@ binascii_a2b_hqx(self, args)
 		Py_DECREF(rv);
 		return NULL;
 	}
-	_PyString_Resize(&rv, (bin_data - (unsigned char *)PyString_AsString(rv)));
-	if ( rv )
-		return Py_BuildValue("Oi", rv, done);
+	_PyString_Resize(
+		&rv, (bin_data - (unsigned char *)PyString_AsString(rv)));
+	if (rv) {
+		PyObject *rrv = Py_BuildValue("Oi", rv, done);
+		Py_DECREF(rv);
+		return rrv;
+	}
 	return NULL;
 }