From: Michael Adam <obnox@samba.org>
Date: Mon, 30 Jan 2012 13:12:15 +0000 (+0100)
Subject: s3:net ads join: interpret return code of ads_kinit_password() in dns update block
X-Git-Tag: tevent-0.9.15~129
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9cd7b8f04d6e51a0be4e18e8842ff1062134afae;p=thirdparty%2Fsamba.git

s3:net ads join: interpret return code of ads_kinit_password() in dns update block

If failed, print according error message and skip the attempt to do dns update.
---

diff --git a/source3/utils/net_ads.c b/source3/utils/net_ads.c
index cb15b76a28c..ecb04ceea61 100644
--- a/source3/utils/net_ads.c
+++ b/source3/utils/net_ads.c
@@ -1498,7 +1498,14 @@ int net_ads_join(struct net_context *c, int argc, const char **argv)
 		}
 
 		strupper_m(ads_dns->auth.realm);
-		ads_kinit_password(ads_dns);
+
+		ret = ads_kinit_password(ads_dns);
+		if (ret != 0) {
+			d_fprintf(stderr,
+				  _("DNS update failed: kinit failed: %s\n"),
+				  error_message(ret));
+			goto dns_done;
+		}
 
 		if (!NT_STATUS_IS_OK(net_update_dns( ctx, ads_dns, NULL))) {
 			d_fprintf( stderr, _("DNS update failed!\n"));