From: Masatake YAMATO Date: Fri, 9 Sep 2022 15:38:37 +0000 (+0900) Subject: tests: (lsfd) fix the potential problems reported by github-code-scan X-Git-Tag: v2.39-rc1~527^2~4 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9d0d32058f42b8b3314251eaed9e0c8782acb366;p=thirdparty%2Futil-linux.git tests: (lsfd) fix the potential problems reported by github-code-scan Use arrays. Signed-off-by: Masatake YAMATO --- diff --git a/tests/ts/lsfd/column-name b/tests/ts/lsfd/column-name index 6db1fc7a69..f87296c9af 100755 --- a/tests/ts/lsfd/column-name +++ b/tests/ts/lsfd/column-name @@ -33,11 +33,13 @@ EXPR="(FD == 3)" { for C in ro-regular-file pidfd socketpair; do coproc MKFDS { + argv=() case $C in socketpair) - argv="$((FD + 1)) socktype=DGRAM" + argv[0]="$((FD + 1))" + argv[1]="socktype=DGRAM" esac - "$TS_HELPER_MKFDS" $C $FD ${argv} + "$TS_HELPER_MKFDS" $C $FD "${argv[@]}" } if read -r -u "${MKFDS[0]}" PID; then ${TS_CMD_LSFD} -n -o ASSOC,KNAME,NAME -p "${PID}" -Q "${EXPR}" | { diff --git a/tests/ts/lsfd/column-type b/tests/ts/lsfd/column-type index 91e7348da5..d31b71254d 100755 --- a/tests/ts/lsfd/column-type +++ b/tests/ts/lsfd/column-type @@ -32,11 +32,13 @@ EXPR="(FD == 3)" { for C in ro-regular-file pidfd inotify socketpair; do coproc MKFDS { + argv=() case $C in socketpair) - argv="$((FD + 1)) socktype=DGRAM" + argv[0]="$((FD + 1))" + argv[1]="socktype=DGRAM" esac - "$TS_HELPER_MKFDS" $C $FD ${argv} + "$TS_HELPER_MKFDS" $C $FD "${argv[@]}" } if read -r -u "${MKFDS[0]}" PID; then ${TS_CMD_LSFD} -n -o ASSOC,STTYPE,TYPE -p "${PID}" -Q "${EXPR}"