From: Gleb Popov <6yearold@gmail.com>
Date: Fri, 10 Oct 2025 13:31:47 +0000 (+0300)
Subject: rc4: Remove the pointless if() operator, its condition is always true
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9d3bb8e3657d15d60c83e84577c17996618bc973;p=thirdparty%2Fopenssl.git

rc4: Remove the pointless if() operator, its condition is always true

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from https://github.com/openssl/openssl/pull/28827)

(cherry picked from commit 10093b63dcdbfa52ad59d53b20bdea9bfa2c5825)
(cherry picked from commit 32b78a35590139d2123af5777da9761b2449f253)
(cherry picked from commit 5bd07407bd4ed82c63486bcbbe2df655cbe97e77)
---

diff --git a/crypto/rc4/rc4_enc.c b/crypto/rc4/rc4_enc.c
index 4015332757e..b2328708c23 100644
--- a/crypto/rc4/rc4_enc.c
+++ b/crypto/rc4/rc4_enc.c
@@ -82,8 +82,7 @@ void RC4(RC4_KEY *key, size_t len, const unsigned char *indata,
             if (--i == 0)
                 break;
             LOOP(indata[6], outdata[6]);
-            if (--i == 0)
-                break;
+            break;
         }
     }
     key->x = x;