From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 5 Apr 2022 08:19:20 +0000 (+0200)
Subject: sd-device: validate devnum parameters in device_set_devnum()
X-Git-Tag: v251-rc2~138^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9d41c62f6eeb50334e155e1f788e132d55d0c8c1;p=thirdparty%2Fsystemd.git

sd-device: validate devnum parameters in device_set_devnum()
---

diff --git a/src/libsystemd/sd-device/sd-device.c b/src/libsystemd/sd-device/sd-device.c
index f9c491c242b..d31526fc222 100644
--- a/src/libsystemd/sd-device/sd-device.c
+++ b/src/libsystemd/sd-device/sd-device.c
@@ -585,11 +585,15 @@ int device_set_devnum(sd_device *device, const char *major, const char *minor) {
                 return r;
         if (maj == 0)
                 return 0;
+        if (!DEVICE_MAJOR_VALID(maj))
+                return -EINVAL;
 
         if (minor) {
                 r = safe_atou(minor, &min);
                 if (r < 0)
                         return r;
+                if (!DEVICE_MINOR_VALID(min))
+                        return -EINVAL;
         }
 
         r = device_add_property_internal(device, "MAJOR", major);