From: Gary Lockyer Date: Thu, 30 Apr 2020 22:42:03 +0000 (+1200) Subject: Fix clang 9 parentheses-equality warnings X-Git-Tag: ldb-2.2.0~569 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9df4d6ab4944c6c606502981517f4e345c5c797e;p=thirdparty%2Fsamba.git Fix clang 9 parentheses-equality warnings Signed-off-by: Gary Lockyer Reviewed-by: Andreas Schneider --- diff --git a/buildtools/wafsamba/samba_autoconf.py b/buildtools/wafsamba/samba_autoconf.py index 2328cfdf2fe..5098648efd7 100644 --- a/buildtools/wafsamba/samba_autoconf.py +++ b/buildtools/wafsamba/samba_autoconf.py @@ -794,7 +794,6 @@ int main(void) { conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=format-nonliteral', testflags=True) conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=for-loop-analysis', testflags=True) conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=missing-field-initializers', testflags=True) - conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=parentheses-equality', testflags=True) conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=unused-function', testflags=True) conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=enum-conversion', testflags=True) conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=logical-not-parentheses', testflags=True) diff --git a/lib/ldb/ldb_mdb/ldb_mdb.c b/lib/ldb/ldb_mdb/ldb_mdb.c index f0a418d07ee..c163321d5a7 100644 --- a/lib/ldb/ldb_mdb/ldb_mdb.c +++ b/lib/ldb/ldb_mdb/ldb_mdb.c @@ -183,7 +183,7 @@ static int lmdb_store(struct ldb_kv_private *ldb_kv, if (flags == TDB_INSERT) { mdb_flags = MDB_NOOVERWRITE; - } else if ((flags == TDB_MODIFY)) { + } else if (flags == TDB_MODIFY) { /* * Modifying a record, ensure that it exists. * This mimics the TDB semantics