From: Nick Mathewson <nickm@torproject.org>
Date: Thu, 27 Sep 2018 17:26:47 +0000 (-0400)
Subject: Prevent duplicate initialization of NSS DH module
X-Git-Tag: tor-0.3.5.3-alpha~32^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9e1a3be0645ca2dad7d6eb8aa00559efec945835;p=thirdparty%2Ftor.git

Prevent duplicate initialization of NSS DH module

Allowing this didn't do any actual harm, since there aren't any
shared structures or leakable objects here.  Still, it's bad style
and might cause trouble in the future.

Closes ticket 27856.
---

diff --git a/src/lib/crypt_ops/crypto_dh_nss.c b/src/lib/crypt_ops/crypto_dh_nss.c
index 9a14b809b4..e2d9040f5e 100644
--- a/src/lib/crypt_ops/crypto_dh_nss.c
+++ b/src/lib/crypt_ops/crypto_dh_nss.c
@@ -53,6 +53,8 @@ crypto_dh_init_nss(void)
   circuit_dh_param.prime.len = DH1024_KEY_LEN;
   circuit_dh_param.base.data = dh_generator_data;
   circuit_dh_param.base.len = 1;
+
+  dh_initialized = 1;
 }
 
 void