From: Andrew Bartlett <abartlet@samba.org>
Date: Mon, 27 Aug 2018 03:01:41 +0000 (+1200)
Subject: torture: Confirm that this element of the krb5.kdc test does not pass against Windows
X-Git-Tag: tdb-1.3.17~1770
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9e1ba904d00cc71d5a14c8ec830052cb091302f5;p=thirdparty%2Fsamba.git

torture: Confirm that this element of the krb5.kdc test does not pass against Windows

This should be fixed, but in the meantime add clue to avoid regressions on
bug 11539.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/torture/krb5/kdc-heimdal.c b/source4/torture/krb5/kdc-heimdal.c
index aa610d33a9f..cc70c9eda67 100644
--- a/source4/torture/krb5/kdc-heimdal.c
+++ b/source4/torture/krb5/kdc-heimdal.c
@@ -174,6 +174,15 @@ static bool torture_check_krb5_error(struct torture_krb5_context *test_context,
 						 rc, 0,
 						 "Got invalid method data");
 
+			/*
+			 * NOTE:
+			 *
+			 * Windows (eg Server 1709) only returns a
+			 * KRB5_PADATA_ETYPE_INFO2 in this situation.
+			 * This test should be fixed but care needs to
+			 * be taken not to reintroduce
+			 * https://bugzilla.samba.org/show_bug.cgi?id=11539
+			 */
 			torture_assert(test_context->tctx,
 				       m.len > 0,
 				       "No PA_DATA given");