From: Davide Sfriso <sfriso@virgilio.it>
Date: Mon, 17 Nov 2008 23:38:56 +0000 (-0800)
Subject: Fix bug #5906 when running winbindd on a Samba PDC. Winbindd crash on 'getent group'
X-Git-Tag: samba-4.0.0alpha6~480^2~209^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9ea794417e8bad3da4236f4071a0d8a23612ac8a;p=thirdparty%2Fsamba.git

Fix bug #5906 when running winbindd on a Samba PDC. Winbindd crash on 'getent group'
Jeremy.
---

diff --git a/source3/winbindd/winbindd_passdb.c b/source3/winbindd/winbindd_passdb.c
index 0cf4540cfef..101854ae943 100644
--- a/source3/winbindd/winbindd_passdb.c
+++ b/source3/winbindd/winbindd_passdb.c
@@ -639,13 +639,13 @@ static NTSTATUS sam_lookup_groupmem(struct winbindd_domain *domain,
 				  sid_type_lookup(lsa_names[i].type)));
 			continue;
 		}
-		if (!((*names)[i] = talloc_strdup((*names),
+		if (!((*names)[num_mapped] = talloc_strdup((*names),
 						  lsa_names[i].name))) {
 			TALLOC_FREE(tmp_ctx);
 			return NT_STATUS_NO_MEMORY;
 		}
 
-		(*name_types)[i] = lsa_names[i].type;
+		(*name_types)[num_mapped] = lsa_names[i].type;
 
 		num_mapped += 1;
 	}