From: Senthil Kumaran <senthil@uthcode.com>
Date: Mon, 4 Jul 2011 04:03:16 +0000 (-0700)
Subject: Fix closes issue12471 - wrong TypeError message when '%i' format spec was used.
X-Git-Tag: v3.2.2rc1~149
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9ebe08d2f6c3b8bca5148e909cc89efeb7a01ad1;p=thirdparty%2FPython%2Fcpython.git

Fix closes issue12471 - wrong TypeError message when '%i' format spec was used.
---

diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
index 97be58793fee..885e740b7663 100644
--- a/Lib/test/test_unicode.py
+++ b/Lib/test/test_unicode.py
@@ -788,6 +788,7 @@ class UnicodeTest(string_tests.CommonTest,
         self.assertEqual('%c' % '\U00021483', '\U00021483')
         self.assertRaises(TypeError, "%c".__mod__, "aa")
         self.assertRaises(ValueError, "%.1\u1032f".__mod__, (1.0/3))
+        self.assertRaises(TypeError, "%i".__mod__, "aa")
 
         # formatting jobs delegated from the string implementation:
         self.assertEqual('...%(foo)s...' % {'foo':"abc"}, '...abc...')
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index 7a70a5e91723..03807a45b9d1 100644
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -9689,8 +9689,6 @@ PyObject *PyUnicode_Format(PyObject *format,
             case 'o':
             case 'x':
             case 'X':
-                if (c == 'i')
-                    c = 'd';
                 isnumok = 0;
                 if (PyNumber_Check(v)) {
                     PyObject *iobj=NULL;
@@ -9705,7 +9703,7 @@ PyObject *PyUnicode_Format(PyObject *format,
                     if (iobj!=NULL) {
                         if (PyLong_Check(iobj)) {
                             isnumok = 1;
-                            temp = formatlong(iobj, flags, prec, c);
+                            temp = formatlong(iobj, flags, prec, (c == 'i'? 'd': c));
                             Py_DECREF(iobj);
                             if (!temp)
                                 goto onError;