From: dongshengyuan <545258830@qq.com> Date: Tue, 14 Jul 2026 10:52:52 +0000 (+0800) Subject: sysupdate: print version details once X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9ed8392a3ceacc06a2c67c0745bdbe74692b86c6;p=thirdparty%2Fsystemd.git sysupdate: print version details once list VERSION printed the version status header twice in plain output. Keep the complete later header and add a regression check. Follow-up for: 42c0b689a800b2ec7cceb1528d3834bf9b3417f8. --- diff --git a/src/sysupdate/sysupdate.c b/src/sysupdate/sysupdate.c index 01b4a03f4d3..9febc9c9c70 100644 --- a/src/sysupdate/sysupdate.c +++ b/src/sysupdate/sysupdate.c @@ -812,21 +812,6 @@ static int context_show_version(Context *c, const char *version) { if (arg_json_format_flags & (SD_JSON_FORMAT_OFF|SD_JSON_FORMAT_PRETTY|SD_JSON_FORMAT_PRETTY_AUTO)) pager_open(arg_pager_flags); - if (!sd_json_format_enabled(arg_json_format_flags)) - printf("%s%s%s Version: %s\n" - " State: %s%s%s\n" - "Installed: %s%s%s%s\n" - "Available: %s%s\n" - "Protected: %s%s%s\n" - " Obsolete: %s%s%s\n\n", - strempty(update_set_flags_to_color(us->flags)), update_set_flags_to_glyph(us->flags), ansi_normal(), us->version, - strempty(update_set_flags_to_color(us->flags)), update_set_flags_to_string(us->flags), ansi_normal(), - yes_no(us->flags & UPDATE_INSTALLED), FLAGS_SET(us->flags, UPDATE_INSTALLED|UPDATE_NEWEST) ? " (newest)" : "", - FLAGS_SET(us->flags, UPDATE_INSTALLED|UPDATE_PENDING) ? " (pending)" : "", FLAGS_SET(us->flags, UPDATE_INSTALLED|UPDATE_PARTIAL) ? " (partial)" : "", - yes_no(us->flags & UPDATE_AVAILABLE), (us->flags & (UPDATE_INSTALLED|UPDATE_AVAILABLE|UPDATE_NEWEST)) == (UPDATE_AVAILABLE|UPDATE_NEWEST) ? " (newest)" : "", - FLAGS_SET(us->flags, UPDATE_INSTALLED|UPDATE_PROTECTED) ? ansi_highlight() : "", yes_no(FLAGS_SET(us->flags, UPDATE_INSTALLED|UPDATE_PROTECTED)), ansi_normal(), - us->flags & UPDATE_OBSOLETE ? ansi_highlight_red() : "", yes_no(us->flags & UPDATE_OBSOLETE), ansi_normal()); - t = table_new("type", "path", "ptuuid", "ptflags", "mtime", "mode", "size", "tries-done", "tries-left", "noauto", "ro", "growfs", "sha256"); if (!t) return log_oom(); diff --git a/test/units/TEST-72-SYSUPDATE.sh b/test/units/TEST-72-SYSUPDATE.sh index d3a8a4bc61f..ba2636ba46c 100755 --- a/test/units/TEST-72-SYSUPDATE.sh +++ b/test/units/TEST-72-SYSUPDATE.sh @@ -1215,6 +1215,7 @@ InstancesMax=1 EOF "$SYSUPDATE" --verify=no update cmp "$WORKDIR/source/sub/blob-v11.bin" "$WORKDIR/blobs/blob-v11.bin" +[[ "$("$SYSUPDATE" --verify=no list v11 | grep -c "Version: v11")" == "1" ]] rm "$CONFIGDIR/01-basename-dir.transfer" # A url-file source pulled via file:// using SHA256SUMS with "sub/blob-v1x.bin" entries