From: Jiri Pirko Date: Wed, 4 Mar 2015 07:36:31 +0000 (+0100) Subject: team: don't traverse port list using rcu in team_set_mac_address X-Git-Tag: v3.16.35~2619 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9f7dbd4035891470f0625dafac8cbe4c0127621d;p=thirdparty%2Fkernel%2Fstable.git team: don't traverse port list using rcu in team_set_mac_address commit 9215f437b85da339a7dfe3db6e288637406f88b2 upstream. Currently the list is traversed using rcu variant. That is not correct since dev_set_mac_address can be called which eventually calls rtmsg_ifinfo_build_skb and there, skb allocation can sleep. So fix this by remove the rcu usage here. Fixes: 3d249d4ca7 "net: introduce ethernet teaming device" Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Luis Henriques --- diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index fa977f9c2e5f0..82fcb2df455b1 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1715,11 +1715,11 @@ static int team_set_mac_address(struct net_device *dev, void *p) if (dev->type == ARPHRD_ETHER && !is_valid_ether_addr(addr->sa_data)) return -EADDRNOTAVAIL; memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); - rcu_read_lock(); - list_for_each_entry_rcu(port, &team->port_list, list) + mutex_lock(&team->lock); + list_for_each_entry(port, &team->port_list, list) if (team->ops.port_change_dev_addr) team->ops.port_change_dev_addr(team, port); - rcu_read_unlock(); + mutex_unlock(&team->lock); return 0; }