From: Philip Withnall Date: Thu, 2 Feb 2017 10:28:22 +0000 (+0000) Subject: signals: Add some missing assertions to inline unit tests X-Git-Tag: dbus-1.11.10~29 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9f9b32dc5cf4e4a05eee73c2f7a238c9f3019899;p=thirdparty%2Fdbus.git signals: Add some missing assertions to inline unit tests check_parse() can return NULL on OOM, which we might as well handle gracefully in the tests with an assertion, rather than an explosion. At least it will shut Coverity up. Coverity ID: 54724 Bug: https://bugs.freedesktop.org/show_bug.cgi?id=99643 Reviewed-by: Simon McVittie --- diff --git a/bus/signals.c b/bus/signals.c index 838161f79..6b7a464cd 100644 --- a/bus/signals.c +++ b/bus/signals.c @@ -2562,7 +2562,9 @@ test_equality (void) _dbus_assert (second_str != NULL); _dbus_assert (strcmp (first_str, second_str) == 0); first_reparsed = check_parse (TRUE, first_str); + _dbus_assert (first_reparsed != NULL); second_reparsed = check_parse (TRUE, second_str); + _dbus_assert (second_reparsed != NULL); _dbus_assert (match_rule_equal (first, first_reparsed)); _dbus_assert (match_rule_equal (second, second_reparsed)); bus_match_rule_unref (first_reparsed); @@ -2581,6 +2583,7 @@ test_equality (void) if (i != j) { second = check_parse (TRUE, equality_tests[j].second); + _dbus_assert (second != NULL); if (match_rule_equal (first, second)) {