From: Nick Mathewson <nickm@torproject.org>
Date: Sat, 26 Apr 2014 04:13:27 +0000 (-0400)
Subject: Fix memory leak in test_util_asprintf
X-Git-Tag: tor-0.2.5.5-alpha~109^2~12
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9fbb5a44b801397be69f5be2c2baff05e93af0f6;p=thirdparty%2Ftor.git

Fix memory leak in test_util_asprintf
---

diff --git a/src/test/test_util.c b/src/test/test_util.c
index 6d6b6dbdf8..256d849919 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -2241,18 +2241,21 @@ test_util_asprintf(void *ptr)
   test_assert(cp);
   test_streq("simple string 100% safe", cp);
   test_eq(strlen(cp), r);
+  tor_free(cp);
 
   /* empty string */
   r = tor_asprintf(&cp, "%s", "");
   test_assert(cp);
   test_streq("", cp);
   test_eq(strlen(cp), r);
+  tor_free(cp);
 
   /* numbers (%i) */
   r = tor_asprintf(&cp, "I like numbers-%2i, %i, etc.", -1, 2);
   test_assert(cp);
   test_streq("I like numbers--1, 2, etc.", cp);
   test_eq(strlen(cp), r);
+  /* don't free cp; next test uses it. */
 
   /* numbers (%d) */
   r = tor_asprintf(&cp2, "First=%d, Second=%d", 101, 202);