From: Guido van Rossum <guido@python.org>
Date: Thu, 28 Mar 2002 20:36:50 +0000 (+0000)
Subject: Backport to 2.2.1:
X-Git-Tag: v2.2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9ff1cf05fbcee1b98a4fc53ed12dc9b134a26f2f;p=thirdparty%2FPython%2Fcpython.git

Backport to 2.2.1:

This is Neil's fix for SF bug 535905 (Evil Trashcan and GC interaction).

The fix makes it possible to call PyObject_GC_UnTrack() more than once
on the same object, and then move the PyObject_GC_UnTrack() call to
*before* the trashcan code is invoked.

BUGFIX CANDIDATE!
---

diff --git a/Modules/gcmodule.c b/Modules/gcmodule.c
index d883b91fe23e..b6c93a9c81ab 100644
--- a/Modules/gcmodule.c
+++ b/Modules/gcmodule.c
@@ -819,7 +819,9 @@ _PyObject_GC_Track(PyObject *op)
 void
 _PyObject_GC_UnTrack(PyObject *op)
 {
-	_PyObject_GC_UNTRACK(op);
+	PyGC_Head *gc = AS_GC(op);
+	if (gc->gc.gc_next != NULL)
+		_PyObject_GC_UNTRACK(op);
 }
 
 PyObject *
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
index e843e760cb90..6698df76471b 100644
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -694,8 +694,8 @@ dict_dealloc(register dictobject *mp)
 {
 	register dictentry *ep;
 	int fill = mp->ma_fill;
+ 	PyObject_GC_UnTrack(mp);
 	Py_TRASHCAN_SAFE_BEGIN(mp)
- 	_PyObject_GC_UNTRACK(mp);
 	for (ep = mp->ma_table; fill > 0; ep++) {
 		if (ep->me_key) {
 			--fill;
diff --git a/Objects/frameobject.c b/Objects/frameobject.c
index cf3d73ac9294..8e4c60ff2722 100644
--- a/Objects/frameobject.c
+++ b/Objects/frameobject.c
@@ -67,8 +67,8 @@ frame_dealloc(PyFrameObject *f)
 	PyObject **fastlocals;
 	PyObject **p;
 
+ 	PyObject_GC_UnTrack(f);
 	Py_TRASHCAN_SAFE_BEGIN(f)
-	_PyObject_GC_UNTRACK(f);
 	/* Kill all local variables */
 	slots = f->f_nlocals + f->f_ncells + f->f_nfreevars;
 	fastlocals = f->f_localsplus;
diff --git a/Objects/listobject.c b/Objects/listobject.c
index dbbc4a99587a..f3821f86fac0 100644
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -195,8 +195,8 @@ static void
 list_dealloc(PyListObject *op)
 {
 	int i;
+	PyObject_GC_UnTrack(op);
 	Py_TRASHCAN_SAFE_BEGIN(op)
-	_PyObject_GC_UNTRACK(op);
 	if (op->ob_item != NULL) {
 		/* Do it backwards, for Christian Tismer.
 		   There's a simple test case where somehow this reduces
diff --git a/Objects/tupleobject.c b/Objects/tupleobject.c
index 27598ed6fe05..ab792def9323 100644
--- a/Objects/tupleobject.c
+++ b/Objects/tupleobject.c
@@ -139,8 +139,8 @@ tupledealloc(register PyTupleObject *op)
 {
 	register int i;
 	register int len =  op->ob_size;
+	PyObject_GC_UnTrack(op);
 	Py_TRASHCAN_SAFE_BEGIN(op)
-	_PyObject_GC_UNTRACK(op);
 	if (len > 0) {
 		i = len;
 		while (--i >= 0)