From: Nikolay Kulikov Date: Tue, 12 May 2026 12:55:33 +0000 (+0300) Subject: staging: rtl8723bs: remove overwriting of current IMR settings X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a00e23438d608c9e9710781f69cbb447672a50f1;p=thirdparty%2Fkernel%2Fstable.git staging: rtl8723bs: remove overwriting of current IMR settings Originally, this code use to Step 1: Read a value from register Step 2: Add some bits to the value Step 3: Write the result back to the same register The problem was that the bits in Step 2 were always zero and didn't change the value, so I have removed that code. Now this function just reads a value and writes the same value back. It is unnecessary and can be removed. Signed-off-by: Nikolay Kulikov Link: https://patch.msgid.link/20260512125703.6878-4-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index f7f6e273c868..91580f6ba52e 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -592,17 +592,12 @@ void rtw_sdio_enable_interrupt(struct adapter *adapter) { struct hal_com_data *haldata; __le32 himr; - u32 tmp; haldata = GET_HAL_DATA(adapter); himr = cpu_to_le32(haldata->sdio_himr); sdio_local_write(adapter, SDIO_REG_HIMR, 4, (u8 *)&himr); - /* Update current system IMR settings */ - tmp = rtw_read32(adapter, REG_HSIMR); - rtw_write32(adapter, REG_HSIMR, tmp); - /* */ /* There are some C2H CMDs have been sent before system interrupt is enabled, e.g., C2H, CPWM. */ /* So we need to clear all C2H events that FW has notified, otherwise FW won't schedule any commands anymore. */