From: Dong-hee Na Date: Thu, 10 Oct 2019 07:41:26 +0000 (+0900) Subject: bpo-38425: Fix ‘res’ may be used uninitialized warning (GH-16688) X-Git-Tag: v3.9.0a1~219 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a05fcd3c7adf6e3a0944da8cf80a3346882e9b3b;p=thirdparty%2FPython%2Fcpython.git bpo-38425: Fix ‘res’ may be used uninitialized warning (GH-16688) --- diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py index 3a9d4e6b4b92..3a821cc9265c 100755 --- a/Parser/asdl_c.py +++ b/Parser/asdl_c.py @@ -1197,7 +1197,6 @@ PyObject* PyAST_mod2obj(mod_ty t) /* mode is 0 for "exec", 1 for "eval" and 2 for "single" input */ mod_ty PyAST_obj2mod(PyObject* ast, PyArena* arena, int mode) { - mod_ty res; PyObject *req_type[3]; const char * const req_name[] = {"Module", "Expression", "Interactive"}; int isinstance; @@ -1223,6 +1222,8 @@ mod_ty PyAST_obj2mod(PyObject* ast, PyArena* arena, int mode) req_name[mode], _PyType_Name(Py_TYPE(ast))); return NULL; } + + mod_ty res = NULL; if (obj2ast_mod(ast, &res, arena) != 0) return NULL; else diff --git a/Python/Python-ast.c b/Python/Python-ast.c index 558d9ebea5c7..e2c703d81555 100644 --- a/Python/Python-ast.c +++ b/Python/Python-ast.c @@ -10250,7 +10250,6 @@ PyObject* PyAST_mod2obj(mod_ty t) /* mode is 0 for "exec", 1 for "eval" and 2 for "single" input */ mod_ty PyAST_obj2mod(PyObject* ast, PyArena* arena, int mode) { - mod_ty res; PyObject *req_type[3]; const char * const req_name[] = {"Module", "Expression", "Interactive"}; int isinstance; @@ -10276,6 +10275,8 @@ mod_ty PyAST_obj2mod(PyObject* ast, PyArena* arena, int mode) req_name[mode], _PyType_Name(Py_TYPE(ast))); return NULL; } + + mod_ty res = NULL; if (obj2ast_mod(ast, &res, arena) != 0) return NULL; else