From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 14 Jul 2020 14:59:22 +0000 (+0200)
Subject: process-util: make sure procfs_file_alloca() works for non-literal field names too
X-Git-Tag: v246-rc2~70^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a07f18cd30ecbfb21c9f39c13563fb9e65450789;p=thirdparty%2Fsystemd.git

process-util: make sure procfs_file_alloca() works for non-literal field names too
---

diff --git a/src/basic/process-util.h b/src/basic/process-util.h
index e0b52246ba5..49bb74ac0ff 100644
--- a/src/basic/process-util.h
+++ b/src/basic/process-util.h
@@ -20,14 +20,16 @@
 #define procfs_file_alloca(pid, field)                                  \
         ({                                                              \
                 pid_t _pid_ = (pid);                                    \
-                const char *_r_;                                        \
+                const char *_field_ = (field);                          \
+                char *_r_;                                              \
                 if (_pid_ == 0) {                                       \
-                        _r_ = ("/proc/self/" field);                    \
+                        _r_ = newa(char, STRLEN("/proc/self/") + strlen(_field_) + 1); \
+                        strcpy(stpcpy(_r_, "/proc/self/"), _field_);    \
                 } else {                                                \
-                        _r_ = newa(char, STRLEN("/proc/") + DECIMAL_STR_MAX(pid_t) + 1 + sizeof(field)); \
-                        sprintf((char*) _r_, "/proc/"PID_FMT"/" field, _pid_); \
+                        _r_ = newa(char, STRLEN("/proc/") + DECIMAL_STR_MAX(pid_t) + 1 + strlen(_field_) + 1); \
+                        sprintf(_r_, "/proc/" PID_FMT "/%s", _pid_, _field_); \
                 }                                                       \
-                _r_;                                                    \
+                (const char*) _r_;                                      \
         })
 
 typedef enum ProcessCmdlineFlags {