From: Timo Sirainen Date: Wed, 8 Jul 2026 07:12:39 +0000 (+0000) Subject: lib: ostream-multiplex - Mark the PACKET format deprecated X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a105370a7ee0e8f78937fd39a5a3f0fe13cffded;p=thirdparty%2Fdovecot%2Fcore.git lib: ostream-multiplex - Mark the PACKET format deprecated The original packet-based framing requires the parent ostream to buffer a whole packet and cannot stream to a parent with max_buffer_size==0, so it does not work with senders that stream directly to the socket. New code should use the STREAM format; PACKET is kept only for backwards compatibility and is being phased out. --- diff --git a/src/lib/ostream-multiplex.h b/src/lib/ostream-multiplex.h index 1e9ea88f35..1ad2107c46 100644 --- a/src/lib/ostream-multiplex.h +++ b/src/lib/ostream-multiplex.h @@ -2,6 +2,14 @@ #define OSTREAM_MULTIPLEX 1 enum ostream_multiplex_format { + /* DEPRECATED: The original packet-based framing + (<32bit length>). It can't stream to a parent + with max_buffer_size==0 and requires the parent to buffer a whole + packet, so it doesn't work with senders that stream directly to the + socket (e.g. imap-fetch). New code should use + OSTREAM_MULTIPLEX_FORMAT_STREAM. Kept only for backwards + compatibility with peers that don't yet understand the stream + format, and is being phased out. */ OSTREAM_MULTIPLEX_FORMAT_PACKET, /* Start a new multiplex ostream */ OSTREAM_MULTIPLEX_FORMAT_STREAM,