From: Markus Elfring Date: Tue, 24 Sep 2024 18:00:09 +0000 (+0200) Subject: soc: mediatek: mtk-svs: Call of_node_put(np) only once in svs_get_subsys_device() X-Git-Tag: v6.13-rc1~139^2~10^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a1643ae9b3e3364edbb6cf285c5f2cf5d60336e6;p=thirdparty%2Fkernel%2Flinux.git soc: mediatek: mtk-svs: Call of_node_put(np) only once in svs_get_subsys_device() An of_node_put(np) call was immediately used after a pointer check for a of_find_device_by_node() call in this function implementation. Thus call such a function only once instead directly before the check. This issue was transformed by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: AngeloGioacchino Del Regno Link: https://lore.kernel.org/r/884f0a5d-e6d3-47dc-8a9e-201bb86b271f@web.de Signed-off-by: AngeloGioacchino Del Regno --- diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index 9a91298c12539..7c349a94b45c0 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -2133,14 +2133,12 @@ static struct device *svs_get_subsys_device(struct svs_platform *svsp, } pdev = of_find_device_by_node(np); + of_node_put(np); if (!pdev) { - of_node_put(np); dev_err(svsp->dev, "cannot find pdev by %s\n", node_name); return ERR_PTR(-ENXIO); } - of_node_put(np); - return &pdev->dev; }