From: Noel Power Date: Fri, 26 Jul 2019 16:18:49 +0000 (+0000) Subject: s4/libcli/raw: clang: Fix 'Dereference of null pointer' X-Git-Tag: talloc-2.3.1~686 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a1a448b19b9565a00e3077690dbda44ed727b2e4;p=thirdparty%2Fsamba.git s4/libcli/raw: clang: Fix 'Dereference of null pointer' Fixes: source4/libcli/raw/rawfileinfo.c:597:2: warning: Dereference of null pointer <--[clang] SMBCLI_CHECK_WCT(req, 10); ^ source4/libcli/raw/rawfileinfo.c:639:2: warning: Dereference of null pointer <--[clang] SMBCLI_CHECK_WCT(req, 11); ^ Signed-off-by: Noel Power Reviewed-by: Andreas Schneider --- diff --git a/source4/libcli/raw/rawfileinfo.c b/source4/libcli/raw/rawfileinfo.c index cbc4fbd4e8b..235b3cd0fa2 100644 --- a/source4/libcli/raw/rawfileinfo.c +++ b/source4/libcli/raw/rawfileinfo.c @@ -597,6 +597,10 @@ static struct smbcli_request *smb_raw_getattr_send(struct smbcli_tree *tree, static NTSTATUS smb_raw_getattr_recv(struct smbcli_request *req, union smb_fileinfo *parms) { + if (req == NULL) { + goto failed; + } + if (!smbcli_request_receive(req) || smbcli_request_is_error(req)) { return smbcli_request_destroy(req); @@ -639,11 +643,15 @@ static struct smbcli_request *smb_raw_getattrE_send(struct smbcli_tree *tree, static NTSTATUS smb_raw_getattrE_recv(struct smbcli_request *req, union smb_fileinfo *parms) { + if (req == NULL) { + goto failed; + } + if (!smbcli_request_receive(req) || smbcli_request_is_error(req)) { return smbcli_request_destroy(req); } - + SMBCLI_CHECK_WCT(req, 11); parms->getattre.out.create_time = raw_pull_dos_date2(req->transport, req->in.vwv + VWV(0));