From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Sat, 17 Sep 2022 21:03:14 +0000 (+0900)
Subject: udev: downgrade log level when device node is already removed
X-Git-Tag: v252-rc1~158
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a1c3628b19ddd9b8eab305806fca1a4f37a33559;p=thirdparty%2Fsystemd.git

udev: downgrade log level when device node is already removed

Follow-up for 790da548b0c37af60aed2f46867ba3885ea78718.
---

diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c
index 7bff3115439..d4622b2f9d8 100644
--- a/src/udev/udev-event.c
+++ b/src/udev/udev-event.c
@@ -1163,6 +1163,7 @@ void udev_event_process_inotify_watch(UdevEvent *event, int inotify_fd) {
                 return;
 
         r = udev_watch_begin(inotify_fd, dev);
-        if (r < 0)
-                log_device_warning_errno(dev, r, "Failed to add inotify watch, ignoring: %m");
+        if (r < 0) /* The device may be already removed, downgrade log level in that case. */
+                log_device_full_errno(dev, r == -ENOENT ? LOG_DEBUG : LOG_WARNING, r,
+                                      "Failed to add inotify watch, ignoring: %m");
 }