From: Guido van Rossum <guido@python.org>
Date: Tue, 3 Jul 2007 14:52:23 +0000 (+0000)
Subject: Fix a subtle bug in PyString_Repr().
X-Git-Tag: v3.0a1~735
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a1cdfd9dc25648bf8db58c32f169baf8d5c73fc3;p=thirdparty%2FPython%2Fcpython.git

Fix a subtle bug in PyString_Repr().
The smartquote code was deciding whether to use ' or "
by inspecting the *output* area...
---

diff --git a/Objects/stringobject.c b/Objects/stringobject.c
index dcecd6f60a87..b5abdb696ee9 100644
--- a/Objects/stringobject.c
+++ b/Objects/stringobject.c
@@ -854,8 +854,9 @@ PyString_Repr(PyObject *obj, int smartquotes)
 		/* figure out which quote to use; single is preferred */
 		quote = '\'';
 		if (smartquotes) {
-			Py_UNICODE *test;
-			for (test = p; test < p+length; ++test) {
+			char *test, *start;
+			start = PyString_AS_STRING(op);
+			for (test = start; test < start+length; ++test) {
 				if (*test == '"') {
 					quote = '\''; /* switch back to single quote */
 					goto decided;