From: Noel Power Date: Mon, 18 Apr 2016 15:20:55 +0000 (+0100) Subject: s4:torture:raw: fix 'Syscall param writev(vector[...])' valgrind error X-Git-Tag: talloc-2.1.7~164 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a22ccb04a030ca9293df74ec0e5b3f8721702ae3;p=thirdparty%2Fsamba.git s4:torture:raw: fix 'Syscall param writev(vector[...])' valgrind error running smbtorture test raw.open.openx-over-dir.openx-over-dir results in the following valgrind trace ==30597== Syscall param writev(vector[...]) points to uninitialised byte(s) ==30597== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==30597== by 0x106CB033: writev_handler (async_sock.c:340) ==30597== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30597== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30597== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==30597== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==30597== by 0x5AE343E: smbcli_request_simple_recv (rawrequest.c:430) ==30597== by 0x5ADC8BC: smb_raw_close (rawfile.c:847) ==30597== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30597== by 0x1A57F0: test_openx_over_dir (open.c:1495) ==30597== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30597== by 0x955368F: internal_torture_run_test (torture.c:442) ==30597== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30597== by 0x2600BD: run_matching (smbtorture.c:110) ==30597== by 0x25FF7F: run_matching (smbtorture.c:95) ==30597== by 0x25FF7F: run_matching (smbtorture.c:95) ==30597== by 0x2601DE: torture_run_named_tests (smbtorture.c:143) ==30597== by 0x261E5D: main (smbtorture.c:665) ==30597== Address 0x187e41d6 is 598 bytes inside a block of size 1,325 alloc'd ==30597== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==30597== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==30597== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==30597== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==30597== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==30597== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==30597== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==30597== by 0x5ADC869: smb_raw_close_send (rawfile.c:832) ==30597== by 0x5ADC8AC: smb_raw_close (rawfile.c:846) ==30597== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30597== by 0x1A57F0: test_openx_over_dir (open.c:1495) ==30597== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30597== by 0x955368F: internal_torture_run_test (torture.c:442) ==30597== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30597== by 0x2600BD: run_matching (smbtorture.c:110) ==30597== by 0x25FF7F: run_matching (smbtorture.c:95) ==30597== by 0x25FF7F: run_matching (smbtorture.c:95) ==30597== by 0x2601DE: torture_run_named_tests (smbtorture.c:143) ==30597== by 0x261E5D: main (smbtorture.c:665) ==30597== Signed-off-by: Noel Power Reviewed-by: Volker Lendecke Reviewed-by: Andreas Schneider --- diff --git a/source4/torture/raw/open.c b/source4/torture/raw/open.c index fb8749d5220..c3cb4841339 100644 --- a/source4/torture/raw/open.c +++ b/source4/torture/raw/open.c @@ -1469,6 +1469,8 @@ static bool test_openx_over_dir(struct torture_context *tctx, struct smbcli_stat int fnum = -1; bool ret = true; + ZERO_STRUCT(io); + torture_assert(tctx, torture_setup_dir(cli, BASEDIR), "Failed to setup up test directory: " BASEDIR); /* Create the Directory */