From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Tue, 9 Jul 2019 10:51:18 +0000 (+1200)
Subject: s3/libsmb/py: avoid null deref with bad python arguments
X-Git-Tag: tdb-1.4.2~573
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a2680b44358b2e85354c88c3fdd525327835e43a;p=thirdparty%2Fsamba.git

s3/libsmb/py: avoid null deref with bad python arguments

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/libsmb/pylibsmb.c b/source3/libsmb/pylibsmb.c
index aac0d95ba07..c09df917251 100644
--- a/source3/libsmb/pylibsmb.c
+++ b/source3/libsmb/pylibsmb.c
@@ -1558,7 +1558,7 @@ static PyObject *py_smb_setacl(struct py_cli_state *self, PyObject *args)
 	if (!sd) {
 		PyErr_Format(PyExc_TypeError,
 			"Expected dcerpc.security.descriptor as argument, got %s",
-			talloc_get_name(pytalloc_get_ptr(py_sd)));
+			pytalloc_get_name(py_sd));
 		return NULL;
 	}