From: John (J5) Palmieri <johnp@redhat.com>
Date: Fri, 24 Feb 2006 16:13:08 +0000 (+0000)
Subject: 2006-02-24  John (J5) Palmieri <johnp@redhat.com>
X-Git-Tag: dbus-0.61~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a2866f736612afc3308a1df33e7902283354e0f9;p=thirdparty%2Fdbus.git

2006-02-24  John (J5) Palmieri <johnp@redhat.com>

	* patch from Sjoerd Simons <sjoerd at debian.org>:

	* dbus/dbus-sysdeps-util.c (_dbus_group_info_free): Moved to
	dbus/dbus-sysdeps.c

	* dbus/dbus-userdb.c (_dbus_group_info_free_allocated): Don't
	call _dbus_group_info_free_allocated which causes infinite loop,
	correctly call _dbus_group_info_free
---

diff --git a/ChangeLog b/ChangeLog
index ff17cef9b..de8641caf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2006-02-24  John (J5) Palmieri <johnp@redhat.com>
+	
+	* patch from Sjoerd Simons <sjoerd at debian.org>:	
+
+	* dbus/dbus-sysdeps-util.c (_dbus_group_info_free): Moved to 
+	dbus/dbus-sysdeps.c
+
+	* dbus/dbus-userdb.c (_dbus_group_info_free_allocated): Don't
+	call _dbus_group_info_free_allocated which causes infinite loop,
+	correctly call _dbus_group_info_free
+
 2006-02-20  Thiago Macieira <thiago.macieira@trolltech.com>
 
 	* qt/qdbusinterface_p.h:
diff --git a/dbus/dbus-sysdeps-util.c b/dbus/dbus-sysdeps-util.c
index 9964b56f7..72db5d34f 100644
--- a/dbus/dbus-sysdeps-util.c
+++ b/dbus/dbus-sysdeps-util.c
@@ -680,17 +680,6 @@ _dbus_group_info_fill_gid (DBusGroupInfo *info,
   return fill_group_info (info, gid, NULL, error);
 }
 
-/**
- * Frees the members of info (but not info itself).
- *
- * @param info the group info
- */
-void
-_dbus_group_info_free (DBusGroupInfo    *info)
-{
-  dbus_free (info->groupname);
-}
-
 /** @} */ /* End of DBusInternalsUtils functions */
 
 /**
diff --git a/dbus/dbus-sysdeps.c b/dbus/dbus-sysdeps.c
index 030d0801f..e8bd9b711 100644
--- a/dbus/dbus-sysdeps.c
+++ b/dbus/dbus-sysdeps.c
@@ -1753,6 +1753,17 @@ _dbus_user_info_free (DBusUserInfo *info)
   dbus_free (info->homedir);
 }
 
+/**
+ * Frees the members of info (but not info itself).
+ *
+ * @param info the group info
+ */
+void
+_dbus_group_info_free (DBusGroupInfo    *info)
+{
+  dbus_free (info->groupname);
+}
+
 /**
  * Sets fields in DBusCredentials to DBUS_PID_UNSET,
  * DBUS_UID_UNSET, DBUS_GID_UNSET.
diff --git a/dbus/dbus-userdb.c b/dbus/dbus-userdb.c
index 83a5769f7..9efc4653f 100644
--- a/dbus/dbus-userdb.c
+++ b/dbus/dbus-userdb.c
@@ -61,7 +61,7 @@ _dbus_group_info_free_allocated (DBusGroupInfo *info)
   if (info == NULL) /* hash table will pass NULL */
     return;
 
-  _dbus_group_info_free_allocated (info);
+  _dbus_group_info_free (info);
   dbus_free (info);
 }