From: Nikita Sobolev <mail@sobolevn.me>
Date: Thu, 16 Mar 2023 13:05:38 +0000 (+0300)
Subject: Add comments to `{typing,_collections_abc}._type_repr` about each other (#102752)
X-Git-Tag: v3.12.0a7~155
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a297d59609038ccfc3bdf6f350e8401f07b0a931;p=thirdparty%2FPython%2Fcpython.git

Add comments to `{typing,_collections_abc}._type_repr` about each other (#102752)

Remove `if` condition in `_collections_abc._type_repr` that's no longer needed, bringing it in sync with `typing._type_repr`.
---

diff --git a/Lib/_collections_abc.py b/Lib/_collections_abc.py
index c62233b81a5c..f86b91a5e6fb 100644
--- a/Lib/_collections_abc.py
+++ b/Lib/_collections_abc.py
@@ -517,9 +517,8 @@ def _type_repr(obj):
 
     Copied from :mod:`typing` since collections.abc
     shouldn't depend on that module.
+    (Keep this roughly in sync with the typing version.)
     """
-    if isinstance(obj, GenericAlias):
-        return repr(obj)
     if isinstance(obj, type):
         if obj.__module__ == 'builtins':
             return obj.__qualname__
diff --git a/Lib/typing.py b/Lib/typing.py
index ab3343956761..3ee9679e50c0 100644
--- a/Lib/typing.py
+++ b/Lib/typing.py
@@ -230,6 +230,9 @@ def _type_repr(obj):
     typically enough to uniquely identify a type.  For everything
     else, we fall back on repr(obj).
     """
+    # When changing this function, don't forget about
+    # `_collections_abc._type_repr`, which does the same thing
+    # and must be consistent with this one.
     if isinstance(obj, type):
         if obj.__module__ == 'builtins':
             return obj.__qualname__