From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Tue, 14 Oct 2025 12:41:15 +0000 (+0200)
Subject: tests(dnsdist): make clang++ happy with OT tests
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a29c3a0c0392e443635296821709ad37fb1be55f;p=thirdparty%2Fpdns.git

tests(dnsdist): make clang++ happy with OT tests
---

diff --git a/pdns/dnsdistdist/test-dnsdist-opentelemetry_cc.cc b/pdns/dnsdistdist/test-dnsdist-opentelemetry_cc.cc
index 32d03a2cb8..5e544a4bbb 100644
--- a/pdns/dnsdistdist/test-dnsdist-opentelemetry_cc.cc
+++ b/pdns/dnsdistdist/test-dnsdist-opentelemetry_cc.cc
@@ -179,13 +179,13 @@ BOOST_AUTO_TEST_CASE(Closer)
   BOOST_ASSERT(trace.resource_spans.at(0).scope_spans.at(0).spans.size() == 4);
 
   BOOST_CHECK_EQUAL(trace.resource_spans.at(0).scope_spans.at(0).spans.at(0).span_id, prespanid);
-  BOOST_CHECK_NE(trace.resource_spans.at(0).scope_spans.at(0).spans.at(0).end_time_unix_nano, 0);
+  BOOST_CHECK_NE(trace.resource_spans.at(0).scope_spans.at(0).spans.at(0).end_time_unix_nano, 0U);
 
   BOOST_CHECK_EQUAL(trace.resource_spans.at(0).scope_spans.at(0).spans.at(1).span_id, postspanid);
-  BOOST_CHECK_NE(trace.resource_spans.at(0).scope_spans.at(0).spans.at(1).end_time_unix_nano, 0);
+  BOOST_CHECK_NE(trace.resource_spans.at(0).scope_spans.at(0).spans.at(1).end_time_unix_nano, 0U);
 
-  BOOST_CHECK_NE(trace.resource_spans.at(0).scope_spans.at(0).spans.at(2).end_time_unix_nano, 0);
-  BOOST_CHECK_NE(trace.resource_spans.at(0).scope_spans.at(0).spans.at(3).end_time_unix_nano, 0);
+  BOOST_CHECK_NE(trace.resource_spans.at(0).scope_spans.at(0).spans.at(2).end_time_unix_nano, 0U);
+  BOOST_CHECK_NE(trace.resource_spans.at(0).scope_spans.at(0).spans.at(3).end_time_unix_nano, 0U);
 
   // Check the parent span_id for the second closer
   BOOST_CHECK_EQUAL(trace.resource_spans.at(0).scope_spans.at(0).spans.at(3).span_id, openevent2SpanID);
@@ -202,7 +202,7 @@ BOOST_AUTO_TEST_CASE(attributes)
 
   // Test that no attributes are added when the tracer is not activated
   auto trace = tracer->getTracesData();
-  BOOST_CHECK_EQUAL(trace.resource_spans.at(0).resource.attributes.size(), 1);
+  BOOST_CHECK_EQUAL(trace.resource_spans.at(0).resource.attributes.size(), 1U);
   BOOST_CHECK_EQUAL(trace.resource_spans.at(0).resource.attributes.at(0).key, "service.name");
 
   // Check if we have a hostname