From: Ondřej Surý <ondrej@sury.org>
Date: Fri, 1 Nov 2019 13:24:35 +0000 (-0500)
Subject: libdns: dns_name_dup() can't fail, change return type to void
X-Git-Tag: v9.15.7~46^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a35b19f80eb88457d8ce8cbaaf474bb8d6537ef3;p=thirdparty%2Fbind9.git

libdns: dns_name_dup() can't fail, change return type to void
---

diff --git a/lib/dns/include/dns/name.h b/lib/dns/include/dns/name.h
index b64092d4457..6b504924916 100644
--- a/lib/dns/include/dns/name.h
+++ b/lib/dns/include/dns/name.h
@@ -1031,7 +1031,7 @@ dns_name_split(const dns_name_t *name, unsigned int suffixlabels,
  *\li	#ISC_R_SUCCESS	No worries.  (This function should always success).
  */
 
-isc_result_t
+void
 dns_name_dup(const dns_name_t *source, isc_mem_t *mctx,
 	     dns_name_t *target);
 /*%<
diff --git a/lib/dns/name.c b/lib/dns/name.c
index e7511944783..3bb2e4fcf86 100644
--- a/lib/dns/name.c
+++ b/lib/dns/name.c
@@ -2159,7 +2159,7 @@ dns_name_split(const dns_name_t *name, unsigned int suffixlabels,
 	return;
 }
 
-isc_result_t
+void
 dns_name_dup(const dns_name_t *source, isc_mem_t *mctx,
 	     dns_name_t *target)
 {
@@ -2193,8 +2193,6 @@ dns_name_dup(const dns_name_t *source, isc_mem_t *mctx,
 		else
 			set_offsets(target, target->offsets, NULL);
 	}
-
-	return (ISC_R_SUCCESS);
 }
 
 isc_result_t