From: Jim Meyering <jim@meyering.net>
Date: Sun, 17 Oct 1999 07:39:20 +0000 (+0000)
Subject: don't compute isdir() of -- or an option string
X-Git-Tag: FILEUTILS-4_0j-trial~168
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a374a307c500f2669166a753136c242ef5674f59;p=thirdparty%2Fcoreutils.git

don't compute isdir() of -- or an option string
---

diff --git a/src/mv.c b/src/mv.c
index 291b531f0a..41d3a92506 100644
--- a/src/mv.c
+++ b/src/mv.c
@@ -438,10 +438,14 @@ main (int argc, char **argv)
   file = argv + optind;
 
   target_directory_specified = (target_directory != NULL);
-  if (!target_directory)
-    target_directory = file[n_files - 1];
+  if (target_directory == NULL)
+    {
+      /* Be careful below.  When n_files is 0, this value will be
+	 argv[0], `--', or an option string.  */
+      target_directory = file[n_files - 1];
+    }
 
-  dest_is_dir = isdir (target_directory);
+  dest_is_dir = (n_files > 0 && isdir (target_directory));
 
   if (target_directory_specified)
     {