From: Stephen Finucane <stephen@that.guru>
Date: Fri, 7 Oct 2016 18:50:46 +0000 (+0100)
Subject: parsearchive: Handle broken patches
X-Git-Tag: v2.0.0-rc1~204
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a39f1e210b2cdeb8da86d658759a78814e727106;p=thirdparty%2Fpatchwork.git

parsearchive: Handle broken patches

Some emails are malformed and missing required fields, e.g. subject.
Keep a counter of all broken mails we receive.

Signed-off-by: Stephen Finucane <stephen@that.guru>
---

diff --git a/patchwork/management/commands/parsearchive.py b/patchwork/management/commands/parsearchive.py
index 1aa505ee..c15971a4 100644
--- a/patchwork/management/commands/parsearchive.py
+++ b/patchwork/management/commands/parsearchive.py
@@ -61,6 +61,7 @@ class Command(BaseCommand):
         }
         duplicates = 0
         dropped = 0
+        errors = 0
 
         # TODO(stephenfin): Support passing via stdin
         path = args and args[0] or options['infile']
@@ -81,6 +82,10 @@ class Command(BaseCommand):
                     dropped += 1
             except django.db.utils.IntegrityError:
                 duplicates += 1
+            except (ValueError, Exception):
+                # TODO(stephenfin): Perhaps we should store the broken patch
+                # somewhere for future reference?
+                errors += 1
 
             if (i % 10) == 0:
                 self.stdout.write('%06d/%06d\r' % (i, count), ending='')
@@ -93,6 +98,7 @@ class Command(BaseCommand):
             '  %(comments)4d comments\n'
             '  %(duplicates)4d duplicates\n'
             '  %(dropped)4d dropped\n'
+            '  %(errors)4d errors\n'
             'Total: %(new)s new entries' % {
                 'total': count,
                 'covers': results[models.CoverLetter],
@@ -100,5 +106,6 @@ class Command(BaseCommand):
                 'comments': results[models.Comment],
                 'duplicates': duplicates,
                 'dropped': dropped,
-                'new': count - duplicates - dropped,
+                'errors': errors,
+                'new': count - duplicates - dropped - errors,
             })